Fix off-by-1 in CallbackStack#pack
#3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
reviewed
Jan 8, 2024
|
Oh, arg. The branch is based right, screwed up the PR. one sec :) |
djspiewak
approved these changes
Jan 8, 2024
|
LGTM, I still see the same effect though. |
|
@mernst-github are you sure? I tried running your reproducer from #3359 (comment) with the debug println I added in #3935 against this PR and it consistently prints |
|
I'm going to merge, since this definitely fixes a bug, but as noted there may still be another issue at large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3935.
An off-by-1 error was causing
pack()to under-report how manyCallbackStacknodes were removed. Thus theclearCounterinIODeferredwas continually growing, causingpacking to occur less and less frequently such that the stack would grow unboundedly large.