Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine steps about post-release scripts #3961

Merged

Conversation

armanbilge
Copy link
Member

Now that I've actually done a release 😂

RELEASING.md Outdated
@@ -14,13 +14,13 @@
1. Publish the release.
1. Wait for all the CI madness to happen, for the release to announced to Discord, and for the artifacts to sync to Maven Central.
1. Make sure you're locally updated and on the right major/minor branch (this is the same branch as step 3).
1. Open a PR to merge the minor branch into the major branch. This is only necessary for patch releases.
1. Run the following script to open two PRs to (1) update the version in the minor branch and then (2) merge the minor branch into the major branch. This script currently works only for patch releases and not for minor releases, milestones, or release candidates, which need special handling.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script currently works only for patch releases and not for minor releases, milestones, or release candidates, which need special handling.

  • For minor releases, we are not merging the minor branch into the major branch, but we are updating the version.
  • For Ms and RCs, we not updating the version, and probably not merging branches either (unless we M/RC a patch, but that seems weird).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Ms and RCs ... and probably not merging branches either

Actually that's not right. Once we hit RCs we are in feature freeze, so it's likely we already have the minor/major branch distinction at that point and need to do the merges.

@djspiewak djspiewak merged commit 6320ad7 into typelevel:series/3.5.x Jan 20, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants