Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #3998 #4001

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix issue #3998 #4001

merged 2 commits into from
Feb 16, 2024

Conversation

durban
Copy link
Contributor

@durban durban commented Feb 16, 2024

Fix take cancelling for unbounded like it already works for bounded.

@durban durban linked an issue Feb 16, 2024 that may be closed by this pull request
Cancelling Async queue take makes other take hang #3998
Closed
@durban durban mentioned this pull request Feb 16, 2024
Closed
djspiewak
djspiewak approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@djspiewak djspiewak merged commit dca88ec into typelevel:series/3.5.x Feb 16, 2024
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
🪲 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelling Async queue take makes other take hang
2 participants
@durban @djspiewak