Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only remove error callback if we've added it #4168

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Only remove error callback if we've added it #4168

merged 3 commits into from
Nov 16, 2024

Conversation

durban
Copy link
Contributor

@durban durban commented Nov 13, 2024

This was probably just an oversight in #2869. It's probably not a big deal, but also, why do unnecessary work...

FIXME: is "enhancement" the correct label for this? Or should it be "backstage"?

armanbilge
armanbilge approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could say it's an "enhancement" b/c it's an optimization. The exact label doesn't matter too much imo :)

@durban durban merged commit dd1c0f5 into typelevel:series/3.5.x Nov 16, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
🍄 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durban @armanbilge