Remove FunctorEmpty and TraverseEmpty #51
Conversation
Issue typelevel#47 cf. https://github.com/typelevel/cats/pull/2405/files One instance cannot be discovered in the RWSTT tests, currently looking into that...
| checkAll("ReaderWriterStateT[Option, Boolean, Int, String, ?]", | ||
| MonadLayerControlTests[ReaderWriterStateT[Option, Boolean, Int, String, ?], Option, (Int, String, ?)] | ||
| .monadLayerControl[Boolean, Boolean]) | ||
| checkAll("MonadLayerControl[ReaderWriterStateT[Option, Boolean, Int, String, ?], Option]", | ||
| SerializableTests.serializable(MonadLayerControl[ReaderWriterStateT[Option, Boolean, Int, String, ?], Option])) | ||
|
|
||
| */ |
There was a problem hiding this comment.
Gotta figure out why this instance is no longer found.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 94.68% 93.09% -1.59%
==========================================
Files 71 63 -8
Lines 734 565 -169
Branches 5 3 -2
==========================================
- Hits 695 526 -169
Misses 39 39
Continue to review full report at Codecov.
|
|
Thanks for this :) Looks good so far (though that instance not being found is odd) |
| @@ -9,6 +9,5 @@ trait AllInstances extends EitherTInstances | |||
| with RaiseInstances with ReaderTInstances | |||
| with LocalInstances with StateInstances | |||
| with StateTInstances with WriterTInstances | |||
| with EmptyInstances with ReaderWriterStateTInstances | |||
There was a problem hiding this comment.
Oh actually it's not odd, you deleted them here 😄
There was a problem hiding this comment.
Oh my God 🤦♂️
Amazing. Thanks Luka, will fix.
There was a problem hiding this comment.
Cool, fixed now!
Adds back accidentally deleted instances
|
Looks like code coverage went down due to the deletion of some hierarchy stuff that referenced |
|
I don't think we need to add that back, this should be fine :) |
|
Cool, sounds good to me! Thanks Luka :) |
Resolves issue #47
cf. https://github.com/typelevel/cats/pull/2405/files
One instance cannot be discovered in the RWSTT tests, currently looking into that... Might need to wait on cats PR2405?