Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document implicit naming convention #1841

Closed
aaronlevin opened this issue Aug 22, 2017 · 2 comments
Closed

Document implicit naming convention #1841

aaronlevin opened this issue Aug 22, 2017 · 2 comments

Comments

@aaronlevin
Copy link
Contributor

aaronlevin commented Aug 22, 2017

We should update the contributing guidelines to specify implicit naming convention. I believe the convention is to prefix the name of the implicit with a camel-cased version of the package namespace. See quote from @peterneyens on a ticket I was working on (adding Traverse instances in the cats.free package):

It is not really documented outside issue #1061 itself (it should probably be added to these guidelines): the implicit values in Cats are prefixed with the package.

So these implicits would be catsFreeFoldableForFree and catsFreeTraverseForFree.

@tbje
Copy link
Contributor

tbje commented Sep 24, 2017

Hey @aaronlevin, did #1920 fix this issue?

@kailuowang
Copy link
Contributor

fixed by #1920 thanks again @tbje

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants