NonEmptyList#groupBy uses universal equality #1959
Comments
|
Yeah this is a bug if you ask me.
On Mon, Oct 9, 2017 at 22:01 Daniel Urban ***@***.***> wrote:
NonEmptyList#groupBy uses universal equality, while we have Eq. This
seems strange.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1959>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJdlorVJbfnBhnx5PLYn05IrFiH-g9ks5sqyRQgaJpZM4PzhWv>
.
--
P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin
|
igstan
added a commit
to igstan/cats
that referenced
this issue
Oct 11, 2017
igstan
added a commit
to igstan/cats
that referenced
this issue
Oct 11, 2017
igstan
added a commit
to igstan/cats
that referenced
this issue
Oct 11, 2017
kailuowang
pushed a commit
that referenced
this issue
Oct 13, 2017
* Require an Order instance for NonEmptyList's groupBy function This addresses: #1959 * There's no mutable TreeMap before Scala 2.12; use only immutable * Don't use `mapValues`, as per code review comments #1964 * Have NonEmptyList.groupBy return a SortedMap instead of just a Map * Have List.groupByNel return a SortedMap as well
|
Fixed by #1964. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NonEmptyList#groupByuses universal equality, while we haveEq. This seems strange.The text was updated successfully, but these errors were encountered: