Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order instance for NonEmptySet #2779

Closed
jatcwang opened this issue Apr 9, 2019 · 1 comment
Closed

Order instance for NonEmptySet #2779

jatcwang opened this issue Apr 9, 2019 · 1 comment

Comments

@jatcwang
Copy link
Contributor

jatcwang commented Apr 9, 2019 •
edited
Loading

Since SortedSet has an ordered instance and NonEmptySet is implemented based on that, should we implement an Order instance for NonEmptySet?

EDIT: Will put in a PR
kailuowang pushed a commit that referenced this issue Jun 11, 2019
@jatcwang @kailuowang
Add Order instance for NonEmptySet (#2779) (#2787)
71bbf39 
* Add Order instance for NonEmptySet (#2779)

- Add Serializable tests for NonEmptySet instances

* remove old catsDataEqForNonEmptySet. Name Order instance properly

* Add CatsDataMimaException to test cats.data package private binary compatibility. Simplify NonEmptySet instances hierachy

* Fix compile error

* remove redundant tests
@LukaJCB
Copy link
Member

LukaJCB commented Jul 3, 2019

Closed by #2787

@LukaJCB LukaJCB closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jatcwang @LukaJCB