Add SemigroupK and MonadCombine instances for StateT. #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| checkAll("StateT[ListWrapper, Int, Int]", MonadStateTests[StateT[ListWrapper, Int, ?], Int].monadState[Int, Int, Int]) | ||
| // checkAll("MonadState[StateT[ListWrapper, Int, ?], Int]", SerializableTests.serializable(MonadState[StateT[ListWrapper, Int, ?], Int])) | ||
| checkAll("MonadState[StateT[List, Int, ?], Int]", SerializableTests.serializable(MonadState[StateT[List, Int, ?], Int])) |
There was a problem hiding this comment.
The serializable tests fail for ListWrapper and List, Option which was tested before, still works.
peterneyens
force-pushed
the
statet-instances
branch
from
d3b2963
to
96b6f4d
Compare
MonadState[StateT[List, Int, ?]] failed the serializable tests.
Current coverage is 88.78%@@ master #1138 diff @@
==========================================
Files 228 228
Lines 3018 3024 +6
Methods 2969 2975 +6
Messages 0 0
Branches 46 47 +1
==========================================
+ Hits 2679 2685 +6
Misses 339 339
Partials 0 0
|
|
LGTM 👍 |
|
👍 Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.