Rename std package to instances #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For typelevel#1135. So far I haven't renamed the `std` within `kernel`. I'm happy to make those changes as well, but I wanted to check with @non and @johnynek. I also didn't rename all of the `catsStdX` instances. Those names seemed fine to me, and some of them have names like `catsStdInstancesForList`, which doesn't translate well if you switch `Std` to `Instances`.
Current coverage is 88.80%@@ master #1140 diff @@
==========================================
Files 228 228
Lines 3028 3028
Methods 2980 2980
Messages 0 0
Branches 46 46
==========================================
Hits 2689 2689
Misses 339 339
Partials 0 0
|
|
👍 |
|
👍 please go ahead and change kernel. We should stabilize now before it is used too much. |
|
@johnynek @kailuowang I've updated the PR to include the change for kernel as well. |
|
👍 |
1 similar comment
|
👍 |
|
👍 (once the conflicts are resolved) |
|
Interesting - I didn't have to resolve any merge conflicts when I merged in master. |
charandas
added a commit
to charandas/scala-whats-that-called
that referenced
this pull request
Dec 7, 2017
Following the changes in cats availabe in current stable 0.9.0 typelevel/cats#1140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1135.
So far I haven't renamed the
stdwithinkernel. I'm happy to makethose changes as well, but I wanted to check with @non and @johnynek.
I also didn't rename all of the
catsStdXinstances. Those names seemedfine to me, and some of them have names like
catsStdInstancesForList,which doesn't translate well if you switch
StdtoInstances.