-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few type classes to generated tuple instances #1527
Conversation
Should we add instances for |
We're going to need generators for our generators. Are we getting the priorities correct? We want It would be interesting if we had some better way to generalize over this. |
I often wonder how long this approach is the right one and whether a shapeless based approach would be almost as fast and much cleaner to maintain. |
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
==========================================
- Coverage 94.02% 91.82% -2.21%
==========================================
Files 256 246 -10
Lines 4201 3754 -447
Branches 84 134 +50
==========================================
- Hits 3950 3447 -503
- Misses 251 307 +56
Continue to review full report at Codecov.
|
@johnynek What about Monoid and Semigroup for example, shouldn't they be different priorities too? @peterneyens I added the three suggested as well. Note this breaks bincompat, and so needs to be for the next release of cats-kernel, whenever that will be. |
If there is concerns over breaking bin comp for kernel we can add these instances in cats.core right? |
these are fine from algebird's point of view. We don't use these traits directly. |
@edmundnoble yes, I think the priority issue might also be a problem for Semigroup. I think it was an oversight. We should probably have resolution tests to make sure things work as expected. Just using Tuple2 is probably enough. |
@edmundnoble I wonder if you have time to finish up this PR? Looks like we are close (1. fix the priority, and 2. add mima exception) |
Continued in #1967 |
No description provided.