Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set simulacrum version to 0.11.0 #1865

Merged
merged 1 commit into from Aug 30, 2017
Merged

Set simulacrum version to 0.11.0 #1865

merged 1 commit into from Aug 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2017

This is required to compile cats for scala 2.13.0-M1.

see https://gitter.im/typelevel/cats-dev?at=59a03515a7b406262dc7722b

See also https://gitter.im/scala/community-builds?at=59a2c72eba0f0f6e38ea700c and links from there as well.

tldr is we wanted to check with scala team if these are known issues on 2.13.0-M1 as well.

This PR will override #1863, so sorry to @shokohara but thanks too!!

@codecov-io
Copy link

codecov-io commented Aug 27, 2017

Codecov Report

Merging #1865 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1865   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         241      241           
  Lines        4193     4193           
  Branches      109      109           
=======================================
  Hits         3982     3982           
  Misses        211      211
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/cartesian.scala 50% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/apply.scala 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db490a...16117c4. Read the comment docs.

@ghost ghost mentioned this pull request Aug 27, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-RC1 Aug 29, 2017
@non
Copy link
Contributor

non commented Aug 30, 2017

LGTM 👍

Thanks!

@kailuowang kailuowang merged commit 8bca114 into typelevel:master Aug 30, 2017
LukaJCB pushed a commit to LukaJCB/cats that referenced this pull request Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants