Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more instances for Hash (#1712): Queue/Duration #1950

Merged
merged 2 commits into from
Oct 6, 2017
Merged

more instances for Hash (#1712): Queue/Duration #1950

merged 2 commits into from
Oct 6, 2017

Conversation

ctongfei
Copy link
Contributor

@ctongfei ctongfei commented Oct 5, 2017

When I wrote Hash (#1712) there's no instances for Queue/Duration.
Now adding Hash instances to these two.

All tests passed. Lines covered. mimaReportBinaryIssues checked.

@codecov-io
Copy link

Codecov Report

Merging #1950 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1950   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files         252     252           
  Lines        4570    4570           
  Branches      118     122    +4     
======================================
  Hits         4369    4369           
  Misses        201     201
Impacted Files Coverage Δ
...el/src/main/scala/cats/kernel/instances/list.scala 100% <100%> (ø) ⬆️
...in/scala/cats/kernel/instances/StaticMethods.scala 89.65% <100%> (+3.29%) ⬆️
.../src/main/scala/cats/kernel/instances/vector.scala 100% <100%> (ø) ⬆️
.../src/main/scala/cats/kernel/instances/stream.scala 100% <100%> (ø) ⬆️
...rc/main/scala/cats/kernel/instances/duration.scala 100% <100%> (ø) ⬆️
...l/src/main/scala/cats/kernel/instances/queue.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c131fe4...fc328ed. Read the comment docs.

@johnynek
Copy link
Contributor

johnynek commented Oct 6, 2017

👍

this is great!

@kailuowang kailuowang merged commit 4ffd3a1 into typelevel:master Oct 6, 2017
@ctongfei ctongfei deleted the more-hash-instances branch October 6, 2017 13:48
@ctongfei
Copy link
Contributor Author

ctongfei commented Oct 6, 2017

thanks :-)

@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants