-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting ready for RC1 #1974
Getting ready for RC1 #1974
Conversation
Would be good to include #1733 in this list. |
CHANGES.md
Outdated
To migrate from 1.0.0-MF. | ||
|
||
* The rename of `Cartesian` to `Semigroupal` and `EitherT.liftT` to `EitherT.liftF` can be done automatically through scalafix we provide. See instructions [here](https://github.com/typelevel/cats/blob/master/scalafix/README.md) | ||
* For `FlatMap`'s `>>` and `<<`, use `Apply`'s `>*` and `<*` instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo - >*
instead of *>
Codecov Report
@@ Coverage Diff @@
## master #1974 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 301 301
Lines 4941 4941
Branches 123 123
=======================================
Hits 4698 4698
Misses 243 243 Continue to review full report at Codecov.
|
I unfortunately cannot comment intelligently on the proposed solution (other than that it would necessitate a |
Since this is a change that could be made in a completely compatible way, I don't see much of a reason that a 1.0 release should be blocked by it. |
@ceedubs that's true, I had the same thought, I included it because the performance penalty seems significant and the fix is simple (if no-one else, I can give it an attack this week), I am going to move it out of the list though. |
What about #1831? I think we should address that in some way maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. This looks good to me.
* [#1922](https://github.com/typelevel/cats/pull/1922) Make kernel laws consistent with core laws by @LukaJCB | ||
* [#1838](https://github.com/typelevel/cats/pull/1838) Sync `NonEmptyList` and `NonEmptyVector` methods by @durban | ||
* [#1914](https://github.com/typelevel/cats/pull/1914) Add `Invariant` instances for kernel type classes by @LukaJCB | ||
* [#1980](https://github.com/typelevel/cats/pull/1980) Make `iterateRight` in `Foldable` sound by @LukaJCB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also a bug fix. I would either list it twice or move it there (I doubt any user will be hit by it as an incompatibility).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My PR approval still stands if you decide to add this @kailuowang :) So go ahead and merge afterwards 🎉
RC1 is the only planned RC release. 1.0.0 would probably be within a month after (unless we found more bugs that neccessets
Outstanding items (ones currently scheduled with RC1)
PRs
Most of them only 1 maintainer approval short.
SortedMap
andSortedSet
instances/MoveSet
andMap
instances to Alleycats #1972Issues
[ ] ??? Consider adding some form newtypes to cats Consider adding some form of newtypes to cats #1800??? If we can't reach consensus on it, we probably have to release without it.
Nice to have
Please add here if you notice any missing items.
Update: removed #1800 from RC1 scope