Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting ready for RC1 #1974

Merged
merged 22 commits into from
Oct 31, 2017
Merged

Getting ready for RC1 #1974

merged 22 commits into from
Oct 31, 2017

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Oct 16, 2017

RC1 is the only planned RC release. 1.0.0 would probably be within a month after (unless we found more bugs that neccessets

Outstanding items (ones currently scheduled with RC1)

PRs

Most of them only 1 maintainer approval short.

Issues

??? If we can't reach consensus on it, we probably have to release without it.

Nice to have

Please add here if you notice any missing items.

Update: removed #1800 from RC1 scope

@iravid
Copy link
Contributor

iravid commented Oct 16, 2017

Would be good to include #1733 in this list. Sync for ReaderT[IO, E, ?] seems very important.

CHANGES.md Outdated
To migrate from 1.0.0-MF.

* The rename of `Cartesian` to `Semigroupal` and `EitherT.liftT` to `EitherT.liftF` can be done automatically through scalafix we provide. See instructions [here](https://github.com/typelevel/cats/blob/master/scalafix/README.md)
* For `FlatMap`'s `>>` and `<<`, use `Apply`'s `>*` and `<*` instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo - >* instead of *>

@codecov-io
Copy link

codecov-io commented Oct 16, 2017

Codecov Report

Merging #1974 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1974   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         301      301           
  Lines        4941     4941           
  Branches      123      123           
=======================================
  Hits         4698     4698           
  Misses        243      243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f4928...2a11955. Read the comment docs.

@kailuowang
Copy link
Contributor Author

@iravid for #1733, @johnynek 's solution seems good, does it necessitate an API addition to in cats (vs. letting users hand roll themselves)? If so, would you propose the new API in the issue?

@iravid
Copy link
Contributor

iravid commented Oct 16, 2017

I unfortunately cannot comment intelligently on the proposed solution (other than that it would necessitate a cats-core -> cats-free dependency) as I don't understand how the usage of flatMap should look after it is implemented.

@ceedubs
Copy link
Contributor

ceedubs commented Oct 16, 2017

Reconsider the use of fold in Validated #1951

Since this is a change that could be made in a completely compatible way, I don't see much of a reason that a 1.0 release should be blocked by it.

@kailuowang
Copy link
Contributor Author

@ceedubs that's true, I had the same thought, I included it because the performance penalty seems significant and the fix is simple (if no-one else, I can give it an attack this week), I am going to move it out of the list though.

@LukaJCB
Copy link
Member

LukaJCB commented Oct 17, 2017

What about #1831? I think we should address that in some way maybe

LukaJCB
LukaJCB previously approved these changes Oct 31, 2017
LukaJCB
LukaJCB previously approved these changes Oct 31, 2017
LukaJCB
LukaJCB previously approved these changes Oct 31, 2017
johnynek
johnynek previously approved these changes Oct 31, 2017
Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. This looks good to me.

* [#1922](https://github.com/typelevel/cats/pull/1922) Make kernel laws consistent with core laws by @LukaJCB
* [#1838](https://github.com/typelevel/cats/pull/1838) Sync `NonEmptyList` and `NonEmptyVector` methods by @durban
* [#1914](https://github.com/typelevel/cats/pull/1914) Add `Invariant` instances for kernel type classes by @LukaJCB
* [#1980](https://github.com/typelevel/cats/pull/1980) Make `iterateRight` in `Foldable` sound by @LukaJCB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also a bug fix. I would either list it twice or move it there (I doubt any user will be hit by it as an incompatibility).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR approval still stands if you decide to add this @kailuowang :) So go ahead and merge afterwards 🎉

@kailuowang kailuowang dismissed stale reviews from johnynek and LukaJCB via 2a11955 October 31, 2017 19:11
@kailuowang kailuowang merged commit 6722f2e into master Oct 31, 2017
@LukaJCB LukaJCB deleted the kailuowang-patch-1 branch October 31, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NonEmptyVector.last
7 participants