Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish adding mapK #2000

Merged
merged 7 commits into from
Oct 31, 2017
Merged

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Oct 31, 2017

Should finish #1987, so we can release RC1 with it! Thanks a lot @andyscott! 😊

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the original PR already got 2 sign-offs I am going to merge this one once build is green.

@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #2000 into master will decrease coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
- Coverage   95.26%   95.08%   -0.19%     
==========================================
  Files         301      301              
  Lines        4921     4941      +20     
  Branches      126      123       -3     
==========================================
+ Hits         4688     4698      +10     
- Misses        233      243      +10
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Func.scala 96.42% <0%> (-3.58%) ⬇️
core/src/main/scala/cats/data/Tuple2K.scala 94.44% <0%> (-2.7%) ⬇️
core/src/main/scala/cats/data/EitherK.scala 97.82% <0%> (-2.18%) ⬇️
free/src/main/scala/cats/free/Yoneda.scala 80% <0%> (-20%) ⬇️
free/src/main/scala/cats/free/Coyoneda.scala 84.61% <0%> (-7.06%) ⬇️
core/src/main/scala/cats/data/Nested.scala 94.82% <0%> (-1.67%) ⬇️
core/src/main/scala/cats/data/OneAnd.scala 96.77% <0%> (-1.59%) ⬇️
core/src/main/scala/cats/data/IndexedStateT.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/EitherT.scala 97.58% <100%> (+0.01%) ⬆️
...in/scala/cats/data/IndexedReaderWriterStateT.scala 100% <100%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3981dd...aac200b. Read the comment docs.

@LukaJCB LukaJCB merged commit 94f4928 into typelevel:master Oct 31, 2017
@LukaJCB LukaJCB deleted the andyscott-feature/add-mapK branch October 31, 2017 14:56
@LukaJCB LukaJCB mentioned this pull request Nov 1, 2017
@kailuowang kailuowang added this to the 1.0.0 milestone Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants