Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2051, Remove superfluous implicit #2053

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix #2051, Remove superfluous implicit #2053

merged 1 commit into from
Nov 30, 2017

Conversation

rsoeldner
Copy link
Contributor

First contribution to cats 🎉 , let me know if something is missing.

@johnynek
Copy link
Contributor

👍

Thank you!

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks, @rsoeldner!

@codecov-io
Copy link

codecov-io commented Nov 30, 2017

Codecov Report

Merging #2053 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   94.95%   94.95%   +<.01%     
==========================================
  Files         311      311              
  Lines        5269     5270       +1     
  Branches      133      133              
==========================================
+ Hits         5003     5004       +1     
  Misses        266      266
Impacted Files Coverage Δ
...in/scala/cats/kernel/laws/discipline/EqTests.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa89fb...416baa3. Read the comment docs.

@LukaJCB
Copy link
Member

LukaJCB commented Nov 30, 2017

Awesome thanks! :)

@LukaJCB LukaJCB merged commit 40465ac into typelevel:master Nov 30, 2017
@kailuowang kailuowang added this to the 1.0.0 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants