Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct >> symbol in FAQ #2084

Merged
merged 3 commits into from
Dec 18, 2017
Merged

correct >> symbol in FAQ #2084

merged 3 commits into from
Dec 18, 2017

Conversation

kailuowang
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 9, 2017

Codecov Report

Merging #2084 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2084   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         325      325           
  Lines        5511     5511           
  Branches      207      207           
=======================================
  Hits         5215     5215           
  Misses        296      296

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda5df3...56cb85b. Read the comment docs.

@@ -218,7 +218,7 @@ All other symbols can be imported with `import cats.implicits._`
| `x === y` | equals | | `Eq[A]` | `eqv(x: A, y: A): Boolean` |
| `x =!= y` | not equals | | `Eq[A]` | `neqv(x: A, y: A): Boolean` |
| `fa >>= f` | flatMap | | `FlatMap[F[_]]` | `flatMap(fa: F[A])(f: A => F[B]): F[B]` |
| `fa >> fb` | followed by | | `FlatMap[F[_]]` | `followedBy(fa: F[A])(fb: F[B]): F[B]` |
| `fa >> fb` | followed by | | `FlatMap[F[_]]` | `>>[B](fb: => F[B]): F[B] = F.flatMap(fa)(_ => fb)` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing something, but it looks like the other methods have the non-symbolic name in the Signature column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems without non-symbolic counterpart when added in #2043

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add one, and << as well? WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most sensible name I can think of is followedBy, but it's taken by Applicative and it won't be released even after the rename. So I don't know. From the discussion #1983 seems that the community's preference is to not have name for such operations. So personally I am fine with this one without name.
Maybe we should fix the documentation here first?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

johnynek
johnynek previously approved these changes Dec 15, 2017
@kailuowang
Copy link
Contributor Author

@ceedubs WDYT?

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ceedubs ceedubs merged commit e8fb7ed into master Dec 18, 2017
@kailuowang kailuowang deleted the kailuowang-patch-3 branch December 19, 2017 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants