-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct >>
symbol in FAQ
#2084
correct >>
symbol in FAQ
#2084
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2084 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 325 325
Lines 5511 5511
Branches 207 207
=======================================
Hits 5215 5215
Misses 296 296 Continue to review full report at Codecov.
|
docs/src/main/tut/faq.md
Outdated
@@ -218,7 +218,7 @@ All other symbols can be imported with `import cats.implicits._` | |||
| `x === y` | equals | | `Eq[A]` | `eqv(x: A, y: A): Boolean` | | |||
| `x =!= y` | not equals | | `Eq[A]` | `neqv(x: A, y: A): Boolean` | | |||
| `fa >>= f` | flatMap | | `FlatMap[F[_]]` | `flatMap(fa: F[A])(f: A => F[B]): F[B]` | | |||
| `fa >> fb` | followed by | | `FlatMap[F[_]]` | `followedBy(fa: F[A])(fb: F[B]): F[B]` | | |||
| `fa >> fb` | followed by | | `FlatMap[F[_]]` | `>>[B](fb: => F[B]): F[B] = F.flatMap(fa)(_ => fb)` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing something, but it looks like the other methods have the non-symbolic name in the Signature
column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems without non-symbolic counterpart when added in #2043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add one, and <<
as well? WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most sensible name I can think of is followedBy
, but it's taken by Applicative
and it won't be released even after the rename. So I don't know. From the discussion #1983 seems that the community's preference is to not have name for such operations. So personally I am fine with this one without name.
Maybe we should fix the documentation here first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
@ceedubs WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.