Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helper addSbtCoursier in project/plugins.sbt #2205

Merged
merged 2 commits into from Mar 28, 2018
Merged

Use helper addSbtCoursier in project/plugins.sbt #2205

merged 2 commits into from Mar 28, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2018

@kailuowang
Copy link
Contributor

I was assuming that this would allow the sbt plugins and their dependencies to be loaded using coursier as well?

@ghost
Copy link
Author

ghost commented Mar 20, 2018

I was assuming that this would allow the sbt plugins and their dependencies to be loaded using coursier as well?

No idea, tbh :) I thought I would just PR the change and see if there is any difference. Also, the comments in the chat will be lost otherwise.

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #2205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files         333      333           
  Lines        5789     5789           
  Branches      222      211   -11     
=======================================
  Hits         5490     5490           
  Misses        299      299
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Const.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d965bbf...ae102e0. Read the comment docs.

@ghost ghost changed the title remove project/project Use helper addSbtCoursier in project/plugins.sbt Mar 24, 2018
@ghost
Copy link
Author

ghost commented Mar 24, 2018

See commit comment coursier/coursier@a743f11

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BennyHill. LGTM

@kailuowang kailuowang merged commit b88f914 into typelevel:master Mar 28, 2018
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants