-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a documentation page for Nested #2369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was long overdue thanks a bunch for working on it! 👏
One thing we should do in the future is to replace the instances of Future
we have in parts of our documentation with IO
, but for now it's alright :)
Yeah actually the example we discussed on Twitter originally used I guess porting the examples to |
Codecov Report
@@ Coverage Diff @@
## master #2369 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 349 349
Lines 5998 5998
Branches 221 222 +1
=======================================
Hits 5699 5699
Misses 299 299 Continue to review full report at Codecov.
|
Yeah we've had the discussion before about Free and what we'd interpret into. I think we could definitely take a dependcy just for the docs module once cats-effect is stable :) |
@LukaJCB having cats-effect as a dependency in docs might make things hairy when we start to have breaking changes (say going 3.0), but I guess in that case we need to coordinate with Cats-effect anyway. So 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much!
If anyone has more motivating examples, I'm happy to add them.