Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonEmptyList#toNem (issue #2346) #2541

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

CucumisSativus
Copy link
Contributor

Here comes the implementation of nel to nem, hope you like it :)

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@CucumisSativus
Copy link
Contributor Author

Build for 2.11 failed because of:

Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x000000077bc53000, 1144705024, 0) failed; error='Cannot allocate memory' (errno=12)

And I cannot rerun the build @LukaJCB could you help there?

@codecov-io
Copy link

Codecov Report

Merging #2541 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2541      +/-   ##
==========================================
+ Coverage   95.17%   95.17%   +<.01%     
==========================================
  Files         359      359              
  Lines        6549     6550       +1     
  Branches      278      273       -5     
==========================================
+ Hits         6233     6234       +1     
  Misses        316      316
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyList.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd6104...2244f7f. Read the comment docs.

@kailuowang kailuowang merged commit e2af59a into typelevel:master Oct 8, 2018
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants