Adding FiniteDuration instances

[calvinbrown085]

closes #2517

[codecov-io]

Codecov Report

Merging #2544 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage   95.18%   95.19%   +0.01%     
==========================================
  Files         359      361       +2     
  Lines        6558     6575      +17     
  Branches      285      289       +4     
==========================================
+ Hits         6242     6259      +17     
  Misses        316      316

Impacted Files	Coverage Δ
...n/scala/cats/kernel/instances/finiteDuration.scala	100% <100%> (ø)
...src/main/scala/cats/instances/finiteDuration.scala	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4880fd0...33cf30d. Read the comment docs.

[LukaJCB]

Can we also add these to cats-core? :)

[calvinbrown085]

@LukaJCB Yes! I'll get those added

[LukaJCB]

I'm sorry I think worded myself incorrectly, what I meant was, that we should re-export the instances in cats.instances and cats.implicits not duplicate them. :)

You can look at other instances in kernel to see how it's done.

[calvinbrown085]

Ah, yeah I think that’s my bad. I probably should have thought of that before duplicating. I’ll get that fixed here :)

[calvinbrown085]

@LukaJCB There we go, this should look a little better.

[LukaJCB]

It should also be added here: https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/instances/package.scala

as well as here: https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/instances/all.scala#L49

[calvinbrown085]

@LukaJCB Thank you, I got those added

[calvinbrown085]

Anyone more familiar with this repo than me, why is the CodeCov pipeline failing?

Am I missing some tests?

[LukaJCB]

@calvinbrown085 You're not testing any of the instances for their laws. Check the LawTests class to see how it's done for other types.

[LukaJCB]

This is binary incompatible, you should create another AllInstancesBinCompat0 trait here, and then mix that into all. :)

[calvinbrown085]

Ah, that might be what I am missing :) Thank you

[LukaJCB]

Of course :)

[LukaJCB]

Looks good to me, thank you! :)

[kailuowang]

Thanks!