Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2631 Fix InvariantMonoidal Laws #2711

Merged

Conversation

wojciechUrbanski
Copy link
Contributor

Changed the parents of InvariantMonoidalTests to invariantSemigroupal and moved the invariant associativity test from InvariantMonoidalTests to InvariantSemigroupalTests

…moved invariant associativity test to InvariantSemigroupalTests
@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #2711 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2711   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         365      365           
  Lines        6795     6795           
  Branches      293      314   +21     
=======================================
  Hits         6464     6464           
  Misses        331      331
Impacted Files Coverage Δ
...c/main/scala/cats/laws/InvariantMonoidalLaws.scala 100% <ø> (ø) ⬆️
...ts/laws/discipline/InvariantSemigroupalTests.scala 100% <100%> (ø) ⬆️
.../cats/laws/discipline/InvariantMonoidalTests.scala 100% <100%> (ø) ⬆️
...ain/scala/cats/laws/InvariantSemigroupalLaws.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17a10...ff6fc1a. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much @wojciechUrbanski, this looks great!

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang modified the milestones: 2.1, 2.0 Feb 5, 2019
@kailuowang kailuowang merged commit 9cc7a74 into typelevel:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants