-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Par functions for Bitraverse #2750
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2750 +/- ##
==========================================
+ Coverage 95.34% 95.35% +0.01%
==========================================
Files 363 363
Lines 6782 6798 +16
Branches 290 286 -4
==========================================
+ Hits 6466 6482 +16
Misses 316 316
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @catostrophe! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
An easy way to clean the commit history up might be hard reset this branch to remote master and then cherry pick your actual change commit 0922a78 then merge the conflicts.
something like
if you don't have an upstream remote yet
git remote add upstream git@github.com:typelevel/cats.git
Then from you branch
git reset --hard upstream/master
git cherry-pick 0922a78
if git reports some conflicts, you can resolve those and run
git add .
git cherry-pick --continue
then finally
git push -f
Also is it possible that we add more tests? I can see that these tests are similar to the ones ParNonEmptyTraverse
has but I am not sure if that's sufficient either. Tests like ParSequence
would be nice IMO.
0922a78
to
9b889c1
Compare
@kailuowang fixed but the doc build is failing :( |
I restarted the build and cleared the cache, should work now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks as always @catostrophe
Added
parBitraverse
,parBisequence
,parLeftTraverse
,parLeftSequence