-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add List#scanLeftNel and List#scanRightNel #3239
add List#scanLeftNel and List#scanRightNel #3239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3239 +/- ##
==========================================
+ Coverage 93.05% 93.05% +<.01%
==========================================
Files 376 376
Lines 7413 7415 +2
Branches 201 201
==========================================
+ Hits 6898 6900 +2
Misses 515 515
Continue to review full report at Codecov.
|
Hey @enzief, thanks for the contribution, this seems pretty useful! Do you mind adding a test or two? Maybe a doctest? :) Much appreciated! |
I think a |
@LukaJCB @rossabaker another look please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks.
.scanLeft
result is always non-empty.