Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3099 to scala_2.11 branch #3249

Conversation

gagandeepkalra
Copy link
Contributor

addresses #3143

@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #3249 into scala_2.11 will decrease coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3249      +/-   ##
==============================================
- Coverage        93.5%   93.45%   -0.06%     
==============================================
  Files             383      383              
  Lines            7149     7153       +4     
  Branches          193      196       +3     
==============================================
  Hits             6685     6685              
- Misses            464      468       +4
Impacted Files Coverage Δ
...tances/ScalaVersionSpecificParallelInstances.scala 0% <0%> (-90.91%) ⬇️
core/src/main/scala/cats/instances/stream.scala 97.4% <100%> (+0.18%) ⬆️
core/src/main/scala/cats/instances/vector.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/list.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/either.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7890320...74db3ac. Read the comment docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this cherry-pick fairly clean? I don't see any mistakes, and tests pass, so I'm inclined to think it's right. But if there's any area that you think deserves extra scrutiny, I'll look harder.

@gagandeepkalra
Copy link
Contributor Author

Actually I didn't cherry-pick, it made things more convoluted given this had a few version specific changes. I went file by file, some experimenting along the way.

@rossabaker
Copy link
Member

Okay, still looks right to me.

@djspiewak djspiewak merged commit ec09ef8 into typelevel:scala_2.11 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants