Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3130 Add foldMapA to foldable #3351

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

gagandeepkalra
Copy link
Contributor

addresses #3143

@codecov-io
Copy link

codecov-io commented Mar 8, 2020

Codecov Report

Merging #3351 into scala_2.11 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3351      +/-   ##
==============================================
+ Coverage       93.39%   93.42%   +0.02%     
==============================================
  Files             389      389              
  Lines            7282     7295      +13     
  Branches          191      186       -5     
==============================================
+ Hits             6801     6815      +14     
+ Misses            481      480       -1
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/foldable.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/queue.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyList.scala 99.35% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0980189...b252999. Read the comment docs.

@travisbrown travisbrown self-requested a review March 10, 2020 08:03
@travisbrown
Copy link
Contributor

Hi @gagandeepkalra! I've just merged six of these backport PRs following the policy change in #3354, but these last four (#3351, #3340, #3334, #3292) have conflicts. Do you mind resolving? I'll go ahead and update the general #3143 checklist.

Thanks again for taking care of these!

@travisbrown travisbrown merged commit 48da041 into typelevel:scala_2.11 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants