Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First two missing instances #3380

Merged
merged 4 commits into from
Apr 6, 2020

Conversation

travisbrown
Copy link
Contributor

Congrats to my colleague @CremboC on finding the first instance that didn't make it into implicit scope:

scala> cats.Semigroup[Map[String, List[Int]]]
                     ^
       error: could not find implicit value for parameter ev: cats.kernel.Semigroup[Map[String,List[Int]]]

This affects any map where the element type doesn't have a commutative semigroup. Pre-2.2.0-M1 usage continues to work fine in 2.2.0-M1, you just need at least the cats.kernel.instances.map._ import.

I've also added a missing Align[Stream] on 2.12, which was turned up in #3378.

I'll give us a couple of days to find any more of these (and maybe fix #3377) and then publish a second milestone.

@codecov-io
Copy link

Codecov Report

Merging #3380 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
- Coverage    91.2%   91.18%   -0.02%     
==========================================
  Files         373      378       +5     
  Lines        7683     7956     +273     
  Branches      197      227      +30     
==========================================
+ Hits         7007     7255     +248     
- Misses        676      701      +25
Flag Coverage Δ
#scala_version_212 ?
#scala_version_213 91.18% <100%> (?)
Impacted Files Coverage Δ
kernel/src/main/scala/cats/kernel/Semigroup.scala 33.33% <100%> (+3.92%) ⬆️
core/src/main/scala/cats/data/OneAnd.scala 79.1% <0%> (-16.49%) ⬇️
core/src/main/scala/cats/Reducible.scala 97.22% <0%> (-2.78%) ⬇️
core/src/main/scala/cats/syntax/either.scala 81.61% <0%> (-1.72%) ⬇️
...rc/main/scala/cats/laws/discipline/arbitrary.scala 98.29% <0%> (-0.86%) ⬇️
core/src/main/scala/cats/data/Tuple2K.scala 91.3% <0%> (-0.19%) ⬇️
core/src/main/scala/cats/instances/try.scala 96.61% <0%> (-0.12%) ⬇️
.../src/main/scala/cats/laws/discipline/MiniInt.scala 97.22% <0%> (-0.08%) ⬇️
core/src/main/scala/cats/data/NonEmptyChain.scala 92.92% <0%> (-0.08%) ⬇️
core/src/main/scala/cats/data/Ior.scala 98.49% <0%> (-0.04%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ad3d7...ebeb063. Read the comment docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djspiewak djspiewak merged commit c1acf25 into typelevel:master Apr 6, 2020
@travisbrown travisbrown added this to the 2.2.0-M2 milestone May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semigroup for NonEmptyMap is kind of weird
4 participants