Reverse argument order for Kleisli ap method #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinhj
changed the title
|
WIP fixes #3450 |
justinhj
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3462 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 382 382
Lines 8315 8319 +4
Branches 210 220 +10
==========================================
+ Hits 7617 7620 +3
- Misses 698 699 +1 |
|
Looks good to me, any reason why this is still a draft? :) |
|
@LukaJCB 👍 Was just waiting for the tests to pass |
djspiewak
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Cats!
This is a kind reminder to run
sbt +prePRand commit the changed files, if any, before submitting.