Avoid all evaluation of NonEmptyLazyList#reduceRightTo #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayahilton
force-pushed
the
avoid-all-evaluation-nll
branch
from
4ae6a6e
to
4939f83
Compare
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 91.33% 91.30% -0.04%
==========================================
Files 386 386
Lines 8612 8614 +2
Branches 240 251 +11
==========================================
- Hits 7866 7865 -1
- Misses 746 749 +3 |
LukaJCB
approved these changes
Aug 18, 2020
barambani
approved these changes
Aug 19, 2020
travisbrown
reviewed
Aug 20, 2020
| @@ -16,6 +16,8 @@ import cats.laws.discipline.arbitrary._ | |||
| import cats.syntax.either._ | |||
| import cats.syntax.foldable._ | |||
| import cats.syntax.eq._ | |||
| import cats.Reducible | |||
| import cats.Eval | |||
There was a problem hiding this comment.
Not important but I'm surprised the alphabetical order here isn't checked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.