Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some helper methods to MonadError #562

Merged
merged 5 commits into from
Oct 8, 2015
Merged

Add some helper methods to MonadError #562

merged 5 commits into from
Oct 8, 2015

Commits on Oct 5, 2015

  1. Add some helper methods to MonadError 

    You should make me write unit tests and ScalaDocs for these before you
merge. I wanted to open a PR before I forgot about this though.
    @ceedubs
    ceedubs committed Oct 5, 2015
    Configuration menu
    Copy the full SHA
    078947d View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2015

  1. Add more MonadError laws 

    These probably don't have the best names. I'm open to naming
suggestions.
    @ceedubs
    ceedubs committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    9d7b23c View commit details
    Browse the repository at this point in the history

  2. Optimized overrides for some MonadError method implementations

    @ceedubs
    ceedubs committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    40d729d View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2015

  1. Add more laws and ScalaDoc for MonadError 

    Many of these "laws" are basically tests for default implementations.
I'm not sure whether or not they should exist in their current form.
This is something that has been talked about in the past, but I don't
think we really reached a verdict on how to go about this.
    @ceedubs
    ceedubs committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    8d4f93c View commit details
    Browse the repository at this point in the history

  2. Fix ScalaDoc reference

    @ceedubs
    ceedubs committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    771980d View commit details
    Browse the repository at this point in the history