Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce OptionT from MonadCombine to Monad #698

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

mikejcurry
Copy link
Contributor

Reduces OptionT MonadCombine instance to Monad.

The MonadCombine instance for OptionT was not tested and does not pass laws.

This addresses #693.
#694 exists for tracking potential changes to laws which may allow this instance, or an alternative type class instance, to be reinstated.

Reduces OptionT to Monad from MonadCombine. MonadCombine for OptionT
was not tested and does not pass laws.
@codecov-io
Copy link

Current coverage is 84.23%

Merging #698 into master will increase coverage by +0.08% as of 1d3fed4

@@            master    #698   diff @@
======================================
  Files          162     162       
  Stmts         2222    2220     -2
  Branches        74      74       
  Methods          0       0       
======================================
  Hit           1870    1870       
  Partial          0       0       
+ Missed         352     350     -2

Review entire Coverage Diff as of 1d3fed4

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Nov 24, 2015

👍 thanks!

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Nov 25, 2015
Reduce OptionT from MonadCombine to Monad
@adelbertc adelbertc merged commit 6469705 into typelevel:master Nov 25, 2015
@mikejcurry mikejcurry deleted the remove-optiont-monadcombine branch December 11, 2015 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants