Add MonadFilter consistency to MonadFilter tests #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `monadFilterConsistency` law was added in 8f7a110 but wasn't hooked up in the tests. This might be better accomplished with something like typelevel#370, but in the interim I think we should at least hook it up.
Current coverage is
|
|
👍 |
ceedubs
added a commit
to ceedubs/cats
that referenced
this pull request
Dec 10, 2015
This is basically the same story as typelevel#728, but it was introduced in fa6457a.
stew
added a commit
that referenced
this pull request
Dec 10, 2015
Add MonadFilter consistency to MonadFilter tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
monadFilterConsistencylaw was added in8f7a110 but wasn't hooked up in the
tests. This might be better accomplished with something like #370, but
in the interim I think we should at least hook it up.