Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey to >= 90% test coverage #941

Merged
merged 4 commits into from
Mar 28, 2016
Merged

Conversation

adelbertc
Copy link
Contributor

Type class composition and MonadState tests

@ngbinh
Copy link
Contributor

ngbinh commented Mar 28, 2016

not sure why this one is still failing. The build was stopped only after ~20 minutes though. Let me try to upgrade scala.js to 0.6.8 (which contains some performance fixes) to see if the problems go away.

@adelbertc
Copy link
Contributor Author

Seems everyone else's builds are succeeding again except this one :( Even after 0.6.8

EDIT I realize it might've been due to my use of List in the new tests. Let's try this again

@codecov-io
Copy link

Current coverage is 89.78%

Merging #941 into master will increase coverage by +0.90% as of 603d318

@@            master    #941   diff @@
======================================
  Files          180     180       
  Stmts         2142    2144     +2
  Branches        42      42       
  Methods          0       0       
======================================
+ Hit           1904    1925    +21
  Partial          0       0       
+ Missed         238     219    -19

Review entire Coverage Diff as of 603d318

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Mar 28, 2016

Current coverage is 89.78%

So close to 90!

👍

@ceedubs ceedubs merged commit f51b977 into typelevel:master Mar 28, 2016
@adelbertc adelbertc deleted the moar-tests branch March 28, 2016 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants