-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax for ApplicativeError #947
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package cats | ||
package syntax | ||
|
||
import cats.data.{Xor, XorT} | ||
|
||
trait ApplicativeErrorSyntax { | ||
implicit def applicativeErrorIdSyntax[E](e: E): ApplicativeErrorIdOps[E] = | ||
new ApplicativeErrorIdOps(e) | ||
|
||
implicit def applicativeErrorSyntax[F[_, _], E, A](fa: F[E, A])(implicit F: ApplicativeError[F[E, ?], E]): ApplicativeErrorOps[F[E, ?], E, A] = | ||
new ApplicativeErrorOps[F[E, ?], E, A](fa) | ||
} | ||
|
||
final class ApplicativeErrorIdOps[E](e: E) { | ||
def raiseError[F[_], A](implicit F: ApplicativeError[F, E]): F[A] = | ||
F.raiseError(e) | ||
} | ||
|
||
final class ApplicativeErrorOps[F[_], E, A](fa: F[A])(implicit F: ApplicativeError[F, E]) { | ||
def handleError(f: E => A): F[A] = | ||
F.handleError(fa)(f) | ||
|
||
def handleErrorWith(f: E => F[A]): F[A] = | ||
F.handleErrorWith(fa)(f) | ||
|
||
def attempt: F[E Xor A] = | ||
F.attempt(fa) | ||
|
||
def attemptT: XorT[F, E, A] = | ||
F.attemptT(fa) | ||
|
||
def recover(pf: PartialFunction[E, A]): F[A] = | ||
F.recover(fa)(pf) | ||
|
||
def recoverWith(pf: PartialFunction[E, F[A]]): F[A] = | ||
F.recoverWith(fa)(pf) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
tests/src/test/scala/cats/tests/ApplicativeErrorTests.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
package cats | ||
package tests | ||
|
||
import cats.data.{Xor, XorT} | ||
|
||
class ApplicativeErrorCheck extends CatsSuite { | ||
|
||
type ErrorOr[A] = String Xor A | ||
|
||
val failed: String Xor Int = | ||
"Badness".raiseError[ErrorOr, Int] | ||
|
||
test("raiseError syntax creates an Xor with the correct type parameters") { | ||
failed should === ("Badness".left[Int]) | ||
} | ||
|
||
test("handleError syntax transforms an error to a success") { | ||
failed.handleError(error => error.length) should === (7.right) | ||
} | ||
|
||
test("handleErrorWith transforms an error to a success") { | ||
failed.handleErrorWith(error => error.length.right) should === (7.right) | ||
} | ||
|
||
test("attempt syntax creates a wrapped Xor") { | ||
failed.attempt should === ("Badness".left.right) | ||
} | ||
|
||
test("attemptT syntax creates an XorT") { | ||
type ErrorOrT[A] = XorT[ErrorOr, String, A] | ||
failed.attemptT should === (XorT[ErrorOr, String, Int](failed.right)) | ||
} | ||
|
||
test("recover syntax transforms an error to a success") { | ||
failed.recover { case error => error.length } should === (7.right) | ||
} | ||
|
||
test("recoverWith transforms an error to a success") { | ||
failed.recoverWith { case error => error.length.right } should === (7.right) | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to be used. Please tell me that it's mere presence doesn't affect whether the next line compiles? :|