Improve Java time meta experience #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide Java time meta instances without requiring any imports. These instances follow the JDBC specification and map a single column type to a java.time class. The Postgres specific instances have been updated to match exactly what the driver allows but the default instances should really be used instead. Any instances for `ZonedDateTime` have been removed. Storing one requires the `LocalDateTime` and `ZoneId` to be stored, it cannot safely be put into an `OffsetDateTime`.
sideeffffect
approved these changes
Dec 21, 2022
|
Thanks for the PR. I'll need to double check that this works for MySQL too (though we don't official support it I'd like to avoid breaking any of their typecheck tests) Specifically from my reading, in MySQL their |
|
Here's some MySQL time instances #1791. Note that I have never used MySQL. |
# Conflicts: # modules/core/src/main/scala/doobie/package.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide Java time meta instances without requiring any imports. These instances follow the JDBC specification and map a single column type to a java.time class.
Any instances for
ZonedDateTimehave been removed. Storing one requires theLocalDateTimeandZoneIdto be stored, it cannot safely be put into anOffsetDateTime.