Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Annotation For ConnectionInterpreter #1899

Conversation

cosmir17
Copy link

I am trying to do 1.0.0-RC2 to RC4 upgrade and I got the following message.

[error] ClassInProjectThatUsesDoobie:76:13: incompatible type in overriding
[error] def getTypeMap: cats.data.Kleisli[F,java.sql.Connection,java.util.Map[String,Class[_]]] (defined in trait Visitor)
[error]   with override def getTypeMap: cats.data.Kleisli[F,java.sql.Connection,java.util.Map[String,Class[_ <: Object]]] (defined in trait ConnectionInterpreter);
[error]  found   : cats.data.Kleisli[F,java.sql.Connection,java.util.Map[String,Class[_ <: Object]]]
[error]  required: cats.data.Kleisli[F,java.sql.Connection,java.util.Map[String,Class[_]]]
[error]         new ConnectionInterpreter {
[error]             ^
[error] one error found

@mergify mergify bot added the free label Jul 28, 2023
@cosmir17
Copy link
Author

cosmir17 commented Jul 28, 2023

I asked @jatcwang for help and he created a github plan page :#1889
However, he seems busy. For that reason, I have worked on this PR. I don't know how to link this PR to the github page.
Can you review, please @jatcwang 🙏

@jatcwang jatcwang added this to the 1.0-RC5 milestone Jul 28, 2023
@jatcwang jatcwang self-assigned this Jul 28, 2023
@jatcwang
Copy link
Collaborator

jatcwang commented Oct 1, 2023

Hi @cosmir17 thanks for the PR. Sorry I was not able to review in time but now I have something more complete. Please take a look at #1929 and let me know what you think :)

@jatcwang jatcwang closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants