Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix future leak #1951

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix future leak #1951

merged 2 commits into from
Nov 17, 2023

Conversation

TimWSpence
Copy link
Member

Fix cancelation leak

@mergify mergify bot added the free label Nov 17, 2023
@TimWSpence
Copy link
Member Author

@armanbilge another for you (sorry 😆). That uncancelable is necessary right?

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another good catch, this looks right!

@jatcwang
Copy link
Collaborator

Thanks :)

@jatcwang jatcwang merged commit dc960d9 into typelevel:main Nov 17, 2023
5 checks passed
@TimWSpence TimWSpence deleted the fix-future-leak branch November 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants