Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query cancellation for streaming queries #2088

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

jatcwang
Copy link
Collaborator

@jatcwang jatcwang commented Sep 1, 2024

Stream.bracket does not allow cancellation in the acquire step which is why we're using bracketFull instead

`Stream.bracket` does not allow cancellation in the `acquire` step which is why we're using `bracketFull` instead
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jatcwang jatcwang merged commit 47e0478 into main Sep 1, 2024
12 checks passed
@jatcwang jatcwang deleted the stream_query_cancellation branch September 1, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants