Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support refined types #571

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

cchantep
Copy link
Collaborator

@cchantep cchantep commented Oct 13, 2021

New frameless-refined module

Closes #257

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #571 (007c323) into master (f25a99c) will decrease coverage by 0.41%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   95.54%   95.13%   -0.42%     
==========================================
  Files          63       65       +2     
  Lines        1101     1131      +30     
  Branches        8       11       +3     
==========================================
+ Hits         1052     1076      +24     
- Misses         49       55       +6     
Flag Coverage Δ
2.12.15 95.13% <81.25%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ataset/src/main/scala/frameless/TypedEncoder.scala 97.12% <50.00%> (-0.46%) ⬇️
...ned/src/main/scala/frameless/refined/package.scala 66.66% <66.66%> (ø)
...taset/src/main/scala/frameless/RecordEncoder.scala 92.59% <80.00%> (-1.00%) ⬇️
...scala/frameless/refined/RefinedFieldEncoders.scala 89.47% <89.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25a99c...007c323. Read the comment docs.

build.sbt Show resolved Hide resolved
@cchantep cchantep force-pushed the feature/257_refined-tests branch 2 times, most recently from 781781c to 7194133 Compare October 13, 2021 12:43
@cchantep cchantep force-pushed the feature/257_refined-tests branch from 7194133 to 9da4122 Compare October 15, 2021 10:40
@cchantep
Copy link
Collaborator Author

Rebased

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 That is awesome! Thanks! Checked it in my project where refined types worked inside Option monads, no regressions noticed.

I left as usual a couple of build / codestyle comments; but they are not critical.

build.sbt Outdated Show resolved Hide resolved
@cchantep cchantep force-pushed the feature/257_refined-tests branch from 9da4122 to 007c323 Compare October 18, 2021 07:56
@cchantep cchantep merged commit d39a330 into typelevel:master Oct 18, 2021
@cchantep cchantep deleted the feature/257_refined-tests branch October 18, 2021 08:47
@pomadchin pomadchin changed the title Close #257 - Support refined types Support refined types Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems writing a Injection for a refined type
2 participants