Fix Spark cross publish #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
commented
Nov 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 65 65
Lines 1134 1134
Branches 12 5 -7
=======================================
Hits 1079 1079
Misses 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
pomadchin
force-pushed
the
fix/spark-cross-publish
branch
2 times, most recently
from
2a1938c to
6e4baab
Compare
pomadchin
force-pushed
the
fix/spark-cross-publish
branch
2 times, most recently
from
55e1cc5 to
18abed3
Compare
pomadchin
force-pushed
the
fix/spark-cross-publish
branch
from
18abed3 to
474a3f3
Compare
pomadchin
commented
Nov 10, 2021
| @@ -48,13 +50,18 @@ lazy val root = Project("frameless", file("." + "frameless")).in(file(".")) | |||
| .settings( | |||
| /** Not all Spark versions support Scala 2.13. These commands are launched for the supported subset of projects only. */ | |||
| commands ++= Seq( | |||
| commandCrossVersion("frameless-test")(projectsCrossVersion.map(_ + "/test") ::: projectsCrossVersion.map(_ + "/test/coverageReport"), "test" :: "coverageReport" :: Nil).value, | |||
| // run tests separately for different Spark versions to reduce pressure on CI | |||
There was a problem hiding this comment.
Even locally it is challenging to run all of these tests in parallel
|
Mering it! Will publish a fresh release after testing snapshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking artifacts today I notcied that
-spark3xartifacts are emtpy 🤦This PR should address this issue, I'll release the
0.11.1shortly after verifying that it works.The local publish now 100% works, still have no idea how it "worked" before 🤦, mb I checked only
coreimports (and it worked since in this case it is a common dep) and than I switched to3.2usage.