Draft: reuse allocated buffer in stream reads for TCP/Unix sockets #3411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3318 I've changed implementation of
SocketPlatform.BufferedReads
to reuse allocatedByteBuffer
for consecutive reads until filled.Also I've moved maximum size of read chunk for
Socket.reads
method to constuctor parameter and made both read and write mutexes optional. Motivation is that if you primary useSocket
instance exclusively by reading/writing from one client via eitherreads/writes
or chain of.flatMap
then your underlyingChannel
access is exclusive 'enough' to opt out of mutex guards.The same logic applies to move of mutex locking for 'reads/writes' over stream itself instead of
read/write
of separate stream chunk: if we reading from or writing into socket with stream, I think we intend to do this without interleaving with other concurrent reads of writes, if any.This PR is a draft, because there is still need to change usage of
AsyncSocket
inUnixSockets
and add some tests for implementation without guards.If this proposed change is acceptable, I'll finish the changes and add tests.