Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoggerFactory instance for NoOpLogger #667

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Conversation

seigert
Copy link
Contributor

@seigert seigert commented Jun 29, 2022

Useful in tests and when your want to disable logging with LoggerFactory[F] altogether.

@seigert seigert requested a review from danicheg July 12, 2022 12:03
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Thank you for your work. One minor suggestion from me:

@danicheg danicheg merged commit 522fc00 into typelevel:main Jul 13, 2022
@danicheg
Copy link
Member

@seigert 2.4.0 is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants