Fix status_code Tag type and add further Tag definitions #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefilim
changed the title
|
Looks good. I'd avoid the change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are really following the OpenTelemetry Semantic Attribute specification, so not sure this is the best place for them but there are no tags defined under the OpenTelemetry module currently.
Also - not sure how important it is to preserve backward compatibility for
def status_code- could add an overloaded function with String parameter if deemed necessary.This PR will be followed with another PR in
natchez-http4sto update invocation tostatus_code, once it's in the correct format (int64 vs string) - at least the AWS Xray collector will correctly export the value and it will be available in the trace data, currently it's just showing as 0.