sdk-trace: add SpanProcessor
#374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
added
tracing
iRevive
force-pushed
the
sdk-trace/span-processor
branch
2 times, most recently
from
d488cd9
to
04d067c
Compare
NthPortal
approved these changes
Nov 17, 2023
sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SpanProcessor.scala
Outdated
Show resolved
Hide resolved
sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/SpanRef.scala
Outdated
Show resolved
Hide resolved
iRevive
force-pushed
the
sdk-trace/span-processor
branch
from
04d067c
to
4f4a3dc
Compare
iRevive
force-pushed
the
sdk-trace/span-processor
branch
from
4f4a3dc
to
d93d4a6
Compare
armanbilge
reviewed
Nov 25, 2023
| * @tparam F | ||
| * the higher-kinded type of a polymorphic effect | ||
| */ | ||
| trait SpanRef[F[_]] { self: Span.Backend[F] => |
There was a problem hiding this comment.
Sorry to be late 😅 but I do think we should bikeshed this name. As far as I understand there is nothing Ref-like here, i.e. you can't set anything. But you may read effectually, which does make it similar to RefSource.
Sorry, I don't have better naming ideas 😕
There was a problem hiding this comment.
Java SDK uses ReadWriteSpan and ReadableSpan.
ReadWriteSpan is not ideal, but more meaningful
| def isEndRequired: Boolean = endOnly.nonEmpty | ||
|
|
||
| def onStart(parentCtx: Option[SpanContext], span: SpanRef[F]): F[Unit] = | ||
| startOnly.parTraverse_(_.onStart(parentCtx, span)) |
There was a problem hiding this comment.
Usual issue here about failure and short-circuiting.
There was a problem hiding this comment.
.attempt should be enough
This was referenced Nov 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadWriteSpan.java
ReadableSpan.java
Why do we need a
SpanRef?Some
SpanProcessors may require access to the internal state of a span (e.g. actual name, SpanData, etc). The changes made to the span must be accessible by the processor. For example, we can implement a span leak detector that determines whether the span is leaked based on the state.P.S. Java SDK calls the interface
ReadableSpanrather thanSpanRef. So, I'm open to better name suggestions :)