sdk-common: add Context
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thoughts on just using |
It's not 'debug-friendly' :( I can think of several scenarios where you would like to dump the whole context into the console to figure out what's happening there. While we can make a key have a debug name (your version of the VaultContext.Key has it), the VaultContext cannot have a meaningful |
iRevive
force-pushed
the
sdk-common/context
branch
from
2ce3f03
to
875cf64
Compare
|
I will merge these changes as is to unblock further development. If there are any concerns, we can mitigate them afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will use this context to carry span details, etc.