Add Attributes#{updated,concat}
#416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
approved these changes
Dec 26, 2023
NthPortal
commented
Dec 26, 2023
core/common/src/main/scala/org/typelevel/otel4s/Attributes.scala
Outdated
Show resolved
Hide resolved
Add `Attributes#updated` as well as `Attributes#+` alias for it. Add `Attributes#concat` invariant overload as well as `Attributes#++` alias for it.
NthPortal
force-pushed
the
enhanced-attributes/PR
branch
from
5fd1b2d
to
bcc230c
Compare
|
@iRevive do you want to wait for another review or merge now? |
Ah, I missed the comment. We can merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Attributes#updatedas well asAttributes#+alias for it.Add
Attributes#concatinvariant overload as well asAttributes#++alias for it.