Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen List AttributeTypes to Seq #512

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Widen List AttributeTypes to Seq #512

merged 2 commits into from
Mar 27, 2024

Conversation

NthPortal
Copy link
Contributor

Resolves #510

@NthPortal NthPortal requested a review from iRevive February 19, 2024 14:31
@NthPortal
Copy link
Contributor Author

NthPortal commented Feb 19, 2024 •
edited
Loading

this currently fails CI because I have yet to figure out how to regenerate semconv locally; however, that should be the only thing it needs

@iRevive
Copy link
Contributor

iRevive commented Mar 18, 2024

If we move forward with this PR, we should also change casting here: https://github.com/typelevel/otel4s/blob/main/sdk-exporter/common/src/main/scala/org/typelevel/otel4s/sdk/exporter/otlp/ProtoEncoder.scala#L74.

@iRevive iRevive mentioned this pull request Mar 23, 2024
Closed
@NthPortal
Copy link
Contributor Author

@iRevive could you regenerate semconv for this?

@iRevive
Copy link
Contributor

iRevive commented Mar 27, 2024

Sure

@iRevive
Copy link
Contributor

iRevive commented Mar 27, 2024

@NthPortal done. I also updated a few places with 'asInstanceOf' casts.

NthPortal and others added 2 commits March 27, 2024 05:02
@NthPortal @iRevive
Widen List AttributeTypes to Seq
80bafb8 
Co-authored-by: Maksym Ochenashko <maxochenashko@gmail.com>
@iRevive @NthPortal
Generate semantic attributes
5e2b292
@NthPortal
Copy link
Contributor Author

done. I also updated a few places with 'asInstanceOf' casts.

thanks!

@NthPortal NthPortal merged commit bf73cfe into typelevel:main Mar 27, 2024
10 checks passed
@NthPortal NthPortal deleted the seq-attributes/PR branch March 27, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRevive iRevive iRevive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Widen List AttributeTypes to Seq
2 participants
@NthPortal @iRevive