Partially redesign Attributes
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow having multiple `Attribute`s with the same name, even if they are of different types. Simplify `Attributes` by no longer having its API treat it like a map—rename `updated` to `added`, make `toMap` package private, and remove the following methods: `contains`, `removed`, `-`, `removedAll`, `--`, `keys`
|
I like the ideas you brought in the #515. Also, they align with #515 (comment). |
iRevive
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow having multiple
Attributes with the same name, even if they are of different types.Simplify
Attributesby no longer having its API treat it like a map—renameupdatedtoadded, maketoMappackage private, and remove the following methods:contains,removed,-,removedAll,--,keysFixes #513
Alternative (that I prefer) to #515