sdk-metrics: add AggregationTemporality
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
added
metrics
iRevive
force-pushed
the
sdk-metrics/aggregation-temporality
branch
2 times, most recently
from
2b526d3
to
0f0856b
Compare
NthPortal
approved these changes
Mar 12, 2024
| * @see | ||
| * [[https://opentelemetry.io/docs/specs/otel/metrics/data-model/#temporality]] | ||
| */ | ||
| sealed trait AggregationTemporality |
There was a problem hiding this comment.
I kind of hate the name, but I don't have a better one
There was a problem hiding this comment.
I would prefer a shorter name too.
But Python, Java, JS, and proto-model use AggregationTemporality. I guess we should too :(
iRevive
force-pushed
the
sdk-metrics/aggregation-temporality
branch
from
0f0856b
to
61bb1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting shaping
sdk-metricsmodule. There is a working prototype.