Add Tracer#currentSpanOrThrow
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
force-pushed
the
currentSpanOrThrow/PR
branch
from
756016a to
ad3a368
Compare
iRevive
reviewed
Mar 23, 2024
core/trace/src/main/scala/org/typelevel/otel4s/trace/Tracer.scala
Outdated
Show resolved
Hide resolved
iRevive
reviewed
Mar 23, 2024
iRevive
approved these changes
Mar 27, 2024
NthPortal
force-pushed
the
currentSpanOrThrow/PR
branch
from
711a345 to
6256b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is that we had an issue with tracing being missing at $work due to a bug (which was my fault), but it took some time to notice that tracing was missing. the bug might have been discovered immediately if it had raised an error rather than silently doing nothing